ui/message_center/views/notification_view.cc - Issue 2620133003: Set slide_out_enabled property for CustomNotification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/message_center/views/notification_view.cc

Issue 2620133003: Set slide_out_enabled property for CustomNotification (Closed)

Patch Set: Addressed comment and added tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/message_center/views/notification_view.cc

diff --git a/ui/message_center/views/notification_view.cc b/ui/message_center/views/notification_view.cc

index 746f0822b8bdb8df86ec5df65c49a584c8456275..c7bdce476419936b85bc8b8daeab80f58cf750ec 100644

--- a/ui/message_center/views/notification_view.cc

+++ b/ui/message_center/views/notification_view.cc

@@ -666,8 +666,6 @@ void NotificationView::CreateOrUpdateActionButtonViews(

void NotificationView::CreateOrUpdateCloseButtonView(

const Notification& notification) {

- set_slide_out_enabled(!notification.pinned());

if (!notification.pinned() && !close_button_) {

PaddedButton* close = new PaddedButton(this);

close->SetPadding(-kCloseIconRightPadding, kCloseIconTopPadding);