Issue 262013004: Fix gn check errors for translate component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262013004: Fix gn check errors for translate component. (Closed)

Created:
6 years, 7 months ago by tfarina

Modified:
6 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix gn check errors for translate component. If you run the following command line, you will get errors like this: $ gn check ERROR at //components/translate/core/browser/translate_accept_languages.cc:13:11: //Include not allowed. ^----------------------- It is not in any dependency of //components/translate:translate_core_browser The include file is in the target(s): //ui/base:ui_base which should somehow be reachable from //components/translate:translate_core_browser Adds missing ui_base dependency to fix this. BUG=367595 TEST=gn check TBR=brettw@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268028