Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2620113002: Make build.py ensure that goma is started if it is enabled (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make build.py ensure that goma is started if it is enabled R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/cf069d2dfa7035a151bdedcd04253e5d0b407ec0

Patch Set 1 #

Patch Set 2 : Better error handling #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M tools/build.py View 1 2 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 11 months ago (2017-01-10 21:46:01 UTC) #2
rmacnak
LGTM
3 years, 11 months ago (2017-01-10 22:02:02 UTC) #3
zra
3 years, 11 months ago (2017-01-10 23:09:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
cf069d2dfa7035a151bdedcd04253e5d0b407ec0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698