predictors: db tool workaround to solve sqlite3 compatibility problem.

tools/resource_prefetch_predictor/prefetch_predictor_tool.py

 #!/usr/bin/python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Inspection of the prefetch predictor database.
 
 On Android, the database can be extracted using:
 adb pull \
   '/data/user/0/$package_name/app_chrome/Default/Network Action Predictor'
   predictor_db
 """
 
 import argparse
 import sqlite3
+import os
 
 from resource_prefetch_predictor_pb2 import (PrefetchData, ResourceData)
 
 
 class Entry(object):
   """Represents an entry in the predictor database."""
   def __init__(
       self, primary_key, proto_buffer):
     self.primary_key = primary_key
     self.prefetch_data = PrefetchData()
@@ skipping 44 matching lines @@
   def PrettyPrintCandidates(self):
     """Prints the candidates for prefetch."""
     print 'primary_key: %s' % self.prefetch_data.primary_key
     for resource in self.prefetch_data.resources:
       confidence = float(resource.number_of_hits) / (
           resource.number_of_hits + resource.number_of_misses)
       if resource.number_of_hits < 2 or confidence < .7:
         continue
       self._PrettyPrintResource(resource)
 
+# The current version of python sqilte3 library doesn't support views but

[Benoit L, 2017/01/11 09:36:45]

Not sure about the "current" version, at least the version we happen to have in
Ubuntu 14.04 LTS.

Also, sqlite3 not sqilte3 :-)

[alexilin, 2017/01/11 12:39:07]

Done.

+# command line util does.
+# TODO(alexilin): get rid of this when python sqlite3 adds view support.
+def CreateCompatibleDatabaseCopy(filename):
+  import tempfile, shutil
+  _, tmpfile = tempfile.mkstemp()
+  shutil.copy2(filename, tmpfile)
+  os.system('sqlite3 %s "DROP VIEW MmapStatus"' % (tmpfile,))

[Benoit L, 2017/01/11 09:36:45]

nit: why not subprocess.call(['sqlite3', tmpfile, 'DROP VIEW MmapStatus'])

?

No shell is best shell.

[alexilin, 2017/01/11 12:39:07]

Done.

+  return tmpfile
 
 def DatabaseStats(filename, domain):
   connection = sqlite3.connect(filename)
   c = connection.cursor()
   query = ('SELECT key, proto FROM resource_prefetch_predictor_host')
   entries = [Entry.FromRow(row) for row in c.execute(query)]
   for x in entries:
     if domain is None or x.primary_key == domain:
       x.PrettyPrintCandidates()
 
 
 def main():
   parser = argparse.ArgumentParser()
   parser.add_argument('-f', dest='database_filename', required=True,
                       help='Path to the database')
   parser.add_argument('-d', dest='domain', default=None, help='Domain')
   args = parser.parse_args()
-  DatabaseStats(args.database_filename, args.domain)
+  database_copy = CreateCompatibleDatabaseCopy(args.database_filename)

[Benoit L, 2017/01/11 09:36:45]

nit:

try:
  bla bla
finally:
  os.remove(database_copy)

To not leave files around.

[alexilin, 2017/01/11 12:39:07]

Done.

+  DatabaseStats(database_copy, args.domain)
+  os.remove(database_copy)
 
 
 if __name__ == '__main__':
   main()