Issue 262002: Make all content scripts from an extension run in the same

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262002: Make all content scripts from an extension run in the same (Closed)

Created:
11 years, 2 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make all content scripts from an extension run in the same isolated world. Chromium side of change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28369

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+129 lines, -13 lines)			Patch
A	chrome/browser/extensions/isolated_world_apitest.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/user_script_slave.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/user_script_slave.cc	View	3 chunks	+25 lines, -2 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world1/a.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world1/b.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world1/background.html	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world1/c.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world1/manifest.json	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world2/a.js	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world2/background.html	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/isolated_world2/manifest.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/api/public/WebFrame.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM. Good tests.

Expand Messages | Collapse Messages