Suggestions UI - Add Data Source and Item

ios/chrome/browser/ui/suggestions/suggestions_data_source.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_DATA_SOURCE_H_
+#define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_DATA_SOURCE_H_
+
+#import <UIKit/UIKit.h>
+
+@class CollectionViewController;
+
+// Data Source for a CollectionViewController populating it with some items and
+// handling the items addition and removal. The items can be added before the

[lpromero, 2017/01/11 09:47:04]

Is removal in one of the follow up CLs?

[gambard, 2017/01/11 15:10:37]

Not yet. I will remove it for now.

+// CollectionViewController is set.

[lpromero, 2017/01/11 09:47:04]

Is this really useful? It adds a lot of complexity in the impl.

[gambard, 2017/01/11 15:10:37]

Done.

+@interface SuggestionsDataSource : NSObject

[marq (ping after 24h), 2017/01/11 13:43:09]

The name 'DataSource" here is confusing, since that's usually the name of a
protocol that a collection view uses. 

[gambard, 2017/01/11 15:10:37]

I have changed the architecture.

+
+// The CollectionViewController for this Data Source. Setting this
+// CollectionViewController will add the currents items in the DataSource to the

[lpromero, 2017/01/11 09:47:04]

s/currents/current?

[gambard, 2017/01/11 15:10:37]

Done.

+// CollectionViewController.
+@property(nonatomic, strong) CollectionViewController* collectionViewController;

[marq (ping after 24h), 2017/01/11 13:43:09]

I don't think this object should be owning the view controller. That doesn't
seem like part of a "data source" object's job.

I also don't really think this pattern is right. I would expect that a data
source object would provide objects to a view controller, so I would expect it
to be a property of the view controller, not the other way around.

+
+// Adds a text item with a |title| and a |subtitle| in the section numbered
+// |section|. If |section| > the current number of section, it will add a new

[lpromero, 2017/01/11 09:47:04]

Avoid ">", make full text sentences.

[gambard, 2017/01/11 15:10:37]

Done.

+// section at the end.

[lpromero, 2017/01/11 09:47:04]

In the impl, passing a section more than "count" would crash. I'd be more
defensive in which section can be passed in.

[gambard, 2017/01/11 15:10:37]

It should not. With the current implementation it works.

+- (void)addTextItem:(NSString*)title
+           subtitle:(NSString*)subtitle
+          toSection:(NSUInteger)section;

[lpromero, 2017/01/11 09:47:04]

Add new line.

[gambard, 2017/01/11 15:10:37]

Done.

+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_DATA_SOURCE_H_