components/autofill/core/browser/contact_info.h - Issue 261993006: Modified to allow to preserve two-word string in first-name and last-name in autofill profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/contact_info.h

Issue 261993006: Modified to allow to preserve two-word string in first-name and last-name in autofill profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added case-insensitivity handling and unit-tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_profile_unittest.cc ('k') | components/autofill/core/browser/contact_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/contact_info.h

diff --git a/components/autofill/core/browser/contact_info.h b/components/autofill/core/browser/contact_info.h

index 007be1be81f5ebb2e5fecb3c8d23aa9f583f962e..cbaeeb6eb4cfeab219a755b719575f1a01c67daf 100644

--- a/components/autofill/core/browser/contact_info.h

+++ b/components/autofill/core/browser/contact_info.h

@@ -22,6 +22,9 @@ class NameInfo : public FormGroup {

virtual ~NameInfo();

NameInfo& operator=(const NameInfo& info);

+ bool operator==(const NameInfo& info);

+ bool operator!=(const NameInfo& info);

Ilya Sherman 2014/06/13 21:13:49 Are these operators still needed, now that you've

Pritam Nikam 2014/06/14 10:27:03 Done. Removed both operators == & !=, as these are

+ bool EqualsIgnoreCase(const NameInfo& info);

Ilya Sherman 2014/06/13 21:13:49 nit: Please leave a blank line before this method

Pritam Nikam 2014/06/14 10:27:03 Done.

// FormGroup:

virtual base::string16 GetRawInfo(ServerFieldType type) const OVERRIDE;

« no previous file with comments | « components/autofill/core/browser/autofill_profile_unittest.cc ('k') | components/autofill/core/browser/contact_info.cc » ('j') | no next file with comments »