components/autofill/core/browser/contact_info.cc - Issue 261993006: Modified to allow to preserve two-word string in first-name and last-name in autofill profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/contact_info.cc

Issue 261993006: Modified to allow to preserve two-word string in first-name and last-name in autofill profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review comments and added unit tests. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/browser/autofill_profile_unittest.cc ('K') | « components/autofill/core/browser/contact_info.h ('k') | components/autofill/core/browser/contact_info_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/contact_info.cc

diff --git a/components/autofill/core/browser/contact_info.cc b/components/autofill/core/browser/contact_info.cc

index 0793bb5ff310c507941a7edd69bca4dfe57345b3..c8ceff5732317588a7bdb49ed14e6bc48a8675a2 100644

--- a/components/autofill/core/browser/contact_info.cc

+++ b/components/autofill/core/browser/contact_info.cc

@@ -34,6 +34,15 @@ NameInfo& NameInfo::operator=(const NameInfo& info) {

return *this;

}

+bool NameInfo::operator==(const NameInfo& info) {

+ return (first_ == info.first_ && middle_ == info.middle_ &&

+ last_ == info.last_);

+bool NameInfo::operator!=(const NameInfo& info) {

+ return !(*this == info);

void NameInfo::GetSupportedTypes(ServerFieldTypeSet* supported_types) const {

supported_types->insert(NAME_FIRST);

supported_types->insert(NAME_MIDDLE);