Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 261993004: Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. (Closed)

Created:
6 years, 7 months ago by michaeln
Modified:
6 years, 7 months ago
Reviewers:
ericu, piman
CC:
chromium-reviews, darin-cc_chromium.org, kinuko+watch, jam, nhiroki, tzik
Visibility:
Public.

Description

Allow BlobDataHandles to be copied, and have their UUIDs read, on any thread. This is a rehash of ericu's cl https://codereview.chromium.org/259773006/ with a fix in upload_data_stream_builder_unittest.cc to resolve the leak asan found. TBR=ericu,piman BUG=108012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -200 lines) Patch
M content/browser/fileapi/blob_storage_context_unittest.cc View 7 chunks +27 lines, -0 lines 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 2 chunks +209 lines, -164 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.h View 1 chunk +27 lines, -8 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.cc View 1 chunk +39 lines, -27 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 7 months ago (2014-05-03 00:39:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/261993004/1
6 years, 7 months ago (2014-05-03 00:40:02 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 03:00:02 UTC) #3
Message was sent while issue was closed.
Change committed as 268023

Powered by Google App Engine
This is Rietveld 408576698