base: Use DiscardableMemoryManager on MacOSX.

base: Use DiscardableMemoryManager on MacOSX.

This limits the address space used for discardable memory on MacOSX
by using the DiscardableMemoryManager for userspace eviction.

Includes some minor refactoring to keep all code using
DiscardableMemoryManager consistent.

BUG=369246
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269640

[reveman, 2014-05-02 23:05:12]

Looks like need this. I can move the refactor/cleanup to a separate patch if you
prefer.

[Philippe, 2014-05-05 08:29:34]

lgtm, thanks David!

[reveman, 2014-05-05 16:41:08]

+willchan

[willchan no longer on Chromium, 2014-05-05 22:39:27]

LGTM

My one bikeshedding nit is SharedState is an extremely generic name. I haven't
thought if there is a better one, but I figured I'd point it out in case you had
any bright ideas. Maybe SharedAllocatorState. Meh, whatever. Up to you.

https://codereview.chromium.org/261993003/diff/1/base/memory/discardable_memo...
File base/memory/discardable_memory_manager_unittest.cc (right):

https://codereview.chromium.org/261993003/diff/1/base/memory/discardable_memo...
base/memory/discardable_memory_manager_unittest.cc:48: : manager_(64 * 1024 *
1024, 12 * 1024 * 1024) {
Can you add a comment here for why you chose these values? Is it safe to change?
I suspect that the constants chosen in the tests are tightly coupled to these
constants. If that's true, please note that.

[reveman, 2014-05-06 14:26:45]

Not a fan of the generic SharedState name either but it at least explains to
some degree what it's supposed to be used for. Normally I'd probably make the
default limits part of a derived class but I figured you guys would not like
that. We can always change this if we find a better name or pattern to use here.

https://codereview.chromium.org/261993003/diff/1/base/memory/discardable_memo...
File base/memory/discardable_memory_manager_unittest.cc (right):

https://codereview.chromium.org/261993003/diff/1/base/memory/discardable_memo...
base/memory/discardable_memory_manager_unittest.cc:48: : manager_(64 * 1024 *
1024, 12 * 1024 * 1024) {
On 2014/05/05 22:39:28, willchan wrote:
> Can you add a comment here for why you chose these values? Is it safe to
change?
> I suspect that the constants chosen in the tests are tightly coupled to these
> constants. If that's true, please note that.

Reduced the size of these constants and added a comment to latest patch.

[reveman, 2014-05-06 14:26:56]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-05-06 14:27:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/261993003/20001

[commit-bot: I haz the power, 2014-05-06 17:30:46]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  ios_dbg_simulator on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-06 20:32:27]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  ios_dbg_simulator on tryserver.chromium
  mac_chromium_rel on tryserver.chromium
  win_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-06 20:38:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-06 20:38:11]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium

[reveman, 2014-05-07 16:30:18]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-05-07 16:33:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/261993003/20001

[commit-bot: I haz the power, 2014-05-07 18:00:34]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
  android_chromium_gn_compile_rel on tryserver.chromium
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  ios_dbg_simulator on tryserver.chromium
  mac_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 20:47:30]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
  android_chromium_gn_compile_rel on tryserver.chromium
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  ios_dbg_simulator on tryserver.chromium
  mac_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 23:34:12]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_aosp on tryserver.chromium
  android_chromium_gn_compile_rel on tryserver.chromium
  android_clang_dbg on tryserver.chromium
  android_dbg on tryserver.chromium
  ios_dbg_simulator on tryserver.chromium
  mac_chromium_rel on tryserver.chromium

[commit-bot: I haz the power, 2014-05-07 23:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-07 23:38:42]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium

[reveman, 2014-05-08 15:12:38]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-05-08 15:15:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/261993003/40001

[commit-bot: I haz the power, 2014-05-08 18:59:15]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-08 19:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-08 19:33:13]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)

[reveman, 2014-05-10 17:11:24]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2014-05-10 17:11:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/reveman@chromium.org/261993003/60001

[commit-bot: I haz the power, 2014-05-11 00:04:20]

Change committed as 269640