Issue 2619923002: Regen DDC error expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2619923002: Regen DDC error expectations (Closed)

Created:
3 years, 11 months ago by vsm

Modified:
3 years, 11 months ago

Reviewers:
Leaf, Jennifer Messerly

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	pkg/dev_compiler/test/codegen_test.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
	M	pkg/dev_compiler/tool/sdk_expected_errors.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 3 (1 generated)

vsm

Committed patchset #1 (id:1) manually as 038a66b305e460487516bba0f24806dada33bd83 (presubmit successful).

3 years, 11 months ago (2017-01-09 23:32:13 UTC) #2

Jennifer Messerly

3 years, 11 months ago (2017-01-09 23:44:50 UTC) #3

Message was sent while issue was closed.

I don't recall any recent inference changes?

in any case LGTM