Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: dashboard/dashboard/speed_releasing.py

Issue 2619883003: More structure for speed releasing. (Closed)
Patch Set: response to comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/speed_releasing.py
diff --git a/dashboard/dashboard/speed_releasing.py b/dashboard/dashboard/speed_releasing.py
index a1ec155ecd5b218bc5abe2880dcb6c65712f756f..fa9c5a0db9bf2bc2509ba93cfc34c922eebb0f63 100644
--- a/dashboard/dashboard/speed_releasing.py
+++ b/dashboard/dashboard/speed_releasing.py
@@ -6,24 +6,55 @@
import json
+from google.appengine.ext import ndb
+
from dashboard.common import request_handler
+from dashboard.models import table_config
class SpeedReleasingHandler(request_handler.RequestHandler):
"""Request handler for requests for speed releasing page."""
- def get(self):
+ def get(self, *args): # pylint: disable=unused-argument
"""Renders the UI for the speed releasing page."""
self.RenderStaticHtml('speed_releasing.html')
- def post(self):
+ def post(self, *args):
"""Returns dynamic data for /speed_releasing.
Outputs:
JSON for the /speed_releasing page XHR request.
"""
+ if args[0]:
+ self._OutputTableJSON(args[0])
+ else:
+ self._OutputHomePageJSON()
+
+ def _OutputTableJSON(self, table_name):
+ table_entity = ndb.Key('TableConfig', table_name).get()
+ if not table_entity:
+ self.response.out.write(json.dumps({'error': 'Invalid table name.'}))
+ return
values = {}
self.GetDynamicVariables(values)
+ master_bot_pairs = []
+ for bot in table_entity.bots:
+ master_bot_pairs.append(bot.parent().string_id() +
+ '/' + bot.string_id())
self.response.out.write(json.dumps({
'xsrf_token': values['xsrf_token'],
+ 'table_bots': master_bot_pairs,
+ 'table_tests': table_entity.tests,
+ 'table_layout': table_entity.table_layout,
+ 'name': table_entity.key.string_id(),
+ }))
+
+ def _OutputHomePageJSON(self):
+ all_entities = table_config.TableConfig.query().fetch()
+ list_of_entities = []
+ for entity in all_entities:
+ list_of_entities.append(entity.key.string_id())
+ self.response.out.write(json.dumps({
+ 'show_list': True,
+ 'list': list_of_entities
}))
« no previous file with comments | « dashboard/dashboard/elements/speed-releasing-table-test.html ('k') | dashboard/dashboard/speed_releasing_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698