Use entities in various ssa helpers.

Use entities in various ssa helpers.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9fb86fe21dd9bafa94fdd2b462fe67a640d355eb

[Johnni Winther, 2017-01-10 15:34:24]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-11 23:58:51]

lgtm

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/interceptor_simplifier.dart (right):

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:241: //
TODO(johnniwinther): Use type argument when all uses of intercepted
nit: 80 col here and below

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/types_propagation.dart (right):

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/types_propagation.dart:284: TypeMask type = new
TypeMask.nonNullSubclass(cls, closedWorld);
just checking: was this .declaration just unnecessary after your previous
change?

[Johnni Winther, 2017-01-12 12:01:48]

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/interceptor_simplifier.dart (right):

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/interceptor_simplifier.dart:241: //
TODO(johnniwinther): Use type argument when all uses of intercepted
On 2017/01/11 23:58:51, Siggi Cherem (dart-lang) wrote:
> nit: 80 col here and below

Done.

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/types_propagation.dart (right):

https://codereview.chromium.org/2619813005/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/types_propagation.dart:284: TypeMask type = new
TypeMask.nonNullSubclass(cls, closedWorld);
On 2017/01/11 23:58:51, Siggi Cherem (dart-lang) wrote:
> just checking: was this .declaration just unnecessary after your previous
> change?

Yes.

[Johnni Winther, 2017-01-12 12:08:27]

Description was changed from

==========
Use entities in various ssa helpers.
==========

to

==========
Use entities in various ssa helpers.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9fb86fe21dd9bafa94fdd2b462fe67a640d355eb
==========

[Johnni Winther, 2017-01-12 12:08:28]

Committed patchset #4 (id:60001) manually as
9fb86fe21dd9bafa94fdd2b462fe67a640d355eb (presubmit successful).