Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2619793002: Add offset to UTF8-decode format exceptions. (Closed)

Created:
3 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
3 years, 11 months ago
Reviewers:
nweiz, floitsch
CC:
reviews_dartlang.org, nweiz
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -8 lines) Patch
M sdk/lib/convert/utf.dart View 7 chunks +17 lines, -8 lines 0 comments Download
M tests/lib/convert/utf8_test.dart View 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-09 15:18:49 UTC) #2
floitsch
LGTM!
3 years, 11 months ago (2017-01-09 15:34:19 UTC) #3
nweiz
Thanks!
3 years, 11 months ago (2017-01-09 22:41:39 UTC) #5
Lasse Reichstein Nielsen
3 years, 11 months ago (2017-01-23 13:18:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb7553c1bd8af7ebf6c9240943d1bef8492ac0bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698