Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2619723004: GN build: Add process_test to precompiled runtime target. (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN build: Add process_test to precompiled runtime target. It is needed to run some I/O tests on Android devices. The buildbots were using an existing (outdated) version, so they continue to work by accident. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/c7aba7d87fbf77a1b8246ed69bb80d293041e6bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 11 months ago (2017-01-10 00:44:01 UTC) #2
rmacnak
lgtm
3 years, 11 months ago (2017-01-10 00:54:50 UTC) #3
Florian Schneider
3 years, 11 months ago (2017-01-10 00:58:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7aba7d87fbf77a1b8246ed69bb80d293041e6bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698