Issue 261963003: Always set the class name on installed functions if the target is the JSGlobal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 261963003: Always set the class name on installed functions if the target is the JSGlobal (Closed)

Created:
6 years, 7 months ago by Toon Verwaest

Modified:
6 years, 7 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Always set the class name on installed functions if the target is the JSGlobal BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21238

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -44 lines)			Patch
	M	src/bootstrapper.cc	View	1	17 chunks	+34 lines, -44 lines	0 comments	Download

Total messages: 3 (0 generated)

Igor Sheludko

lgtm with comments that you can ignore if they do not make sense: https://codereview.chromium.org/261963003/diff/1/src/bootstrapper.cc File ...

6 years, 7 months ago (2014-05-07 18:45:05 UTC) #2

Toon Verwaest

6 years, 7 months ago (2014-05-09 17:21:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21238 (presubmit successful).