Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2619623002: Fix code for @failingTest refactoring tests. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix code for @failingTest refactoring tests. We should have used 'super.name()'. Some tests are now passing. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/12bdc9eb953d73f28ff81b88d11cead3c83e132a

Patch Set 1 #

Patch Set 2 : Also update correction tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -52 lines) Patch
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 1 chunk +27 lines, -26 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-06 21:28:55 UTC) #1
Brian Wilkerson
lgtm Sorry I didn't notice that.
3 years, 11 months ago (2017-01-06 21:50:06 UTC) #2
scheglov
3 years, 11 months ago (2017-01-06 21:53:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
12bdc9eb953d73f28ff81b88d11cead3c83e132a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698