Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2619603002: Remove android_java_ui as it is not used (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index dbfff0a06a54116bc6cf478efaabb8576e6d4d24..53a0e8a2b6ed4494c23a06ea774d22c114a772e0 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -258,7 +258,7 @@
#include "components/crash/content/browser/crash_handler_host_linux.h"
#endif
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
#include "chrome/browser/android/ntp/new_tab_page_url_handler.h"
#include "chrome/browser/android/service_tab_launcher.h"
#include "chrome/browser/android/webapps/single_tab_mode_tab_helper.h"
@@ -695,7 +695,7 @@ class CertificateReportingServiceCertReporter : public SSLCertReporter {
DISALLOW_COPY_AND_ASSIGN(CertificateReportingServiceCertReporter);
};
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
void HandleSingleTabModeBlockOnUIThread(const BlockedWindowParams& params) {
WebContents* web_contents = tab_util::GetWebContentsByFrameID(
params.render_process_id(), params.opener_render_frame_id());
@@ -704,7 +704,7 @@ void HandleSingleTabModeBlockOnUIThread(const BlockedWindowParams& params) {
SingleTabModeTabHelper::FromWebContents(web_contents)->HandleOpenUrl(params);
}
-#endif // BUILDFLAG(ANDROID_JAVA_UI)
+#endif // defined(OS_ANDROID)
#if defined(OS_ANDROID)
Ted C 2017/01/06 22:33:30 combine with above
F 2017/01/09 21:36:32 Done.
float GetDeviceScaleAdjustment() {
@@ -1526,7 +1526,7 @@ void MaybeAppendBlinkSettingsSwitchForFieldTrial(
base::JoinString(blink_settings, ","));
}
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
void ForwardShareServiceRequest(
base::WeakPtr<service_manager::InterfaceProvider> interface_provider,
blink::mojom::ShareServiceRequest request) {
@@ -2377,7 +2377,7 @@ bool ChromeContentBrowserClient::CanCreateWindow(
}
}
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
if (SingleTabModeTabHelper::IsRegistered(opener_render_process_id,
opener_render_frame_id)) {
BrowserThread::PostTask(BrowserThread::UI,
@@ -2550,7 +2550,7 @@ void ChromeContentBrowserClient::BrowserURLHandlerCreated(
handler->AddHandlerPair(&WillHandleBrowserAboutURL,
BrowserURLHandler::null_handler());
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
// Handler to rewrite chrome://newtab on Android.
handler->AddHandlerPair(&chrome::android::HandleAndroidNativePageURL,
BrowserURLHandler::null_handler());
@@ -3001,7 +3001,7 @@ void ChromeContentBrowserClient::RegisterRenderFrameMojoInterfaces(
BindSensitiveInputVisibilityService,
render_frame_host));
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
content::WebContents* web_contents =
content::WebContents::FromRenderFrameHost(render_frame_host);
if (web_contents) {
@@ -3121,7 +3121,7 @@ void ChromeContentBrowserClient::OpenURL(
const base::Callback<void(content::WebContents*)>& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
-#if BUILDFLAG(ANDROID_JAVA_UI)
+#if defined(OS_ANDROID)
ServiceTabLauncher::GetInstance()->LaunchTab(browser_context, params,
callback);
#else

Powered by Google App Engine
This is Rietveld 408576698