Chromium Code Reviews| Index: chrome/android/BUILD.gn |
| diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn |
| index eca238a28c146f976e676a296a52e86b0ca8fe86..171dad55ae6acd8fad440ae674b26d28927646f6 100644 |
| --- a/chrome/android/BUILD.gn |
| +++ b/chrome/android/BUILD.gn |
| @@ -232,49 +232,45 @@ android_library("chrome_java") { |
| # Manifest used for linting (determining unused resources). |
| android_manifest = chrome_public_android_manifest |
| - # TODO(sievers): Split java code into components. Not everything |
| - # is really all that UI related here. |
| - if (android_java_ui) { |
| - # From java_sources.gni. |
| - java_files = chrome_java_sources |
| - |
| - srcjar_deps += [ |
| - "//chrome:page_info_connection_type_javagen", |
| - "//chrome:website_settings_action_javagen", |
| - "//components/browsing_data/core:browsing_data_utils_java", |
| - "//components/infobars/core:infobar_enums_java", |
| - "//components/ntp_snippets:ntp_snippets_java_enums_srcjar", |
| - "//components/ntp_tiles:ntp_tiles_enums_java", |
| - "//components/offline_pages/core:offline_page_model_enums_java", |
| - "//components/omnibox/browser:autocomplete_match_javagen", |
| - "//components/omnibox/browser:autocomplete_match_type_javagen", |
| - "//components/security_state/core:security_state_enums_java", |
| - "//components/signin/core/browser:investigated_scenario_java", |
| - ] |
| - |
| - deps += [ |
| - ":chrome_java_resources", |
| - ":document_tab_model_info_proto_java", |
| - "//blimp/client/public:public_java", |
| - "//components/bookmarks/common/android:bookmarks_java", |
| - "//components/dom_distiller/content/browser/android:dom_distiller_content_java", |
| - "//components/dom_distiller/core/android:dom_distiller_core_java", |
| - "//components/gcm_driver/android:gcm_driver_java", |
| - "//components/gcm_driver/instance_id/android:instance_id_driver_java", |
| - "//components/invalidation/impl:java", |
| - "//components/location/android:location_java", |
| - "//components/navigation_interception/android:navigation_interception_java", |
| - "//components/ntp_tiles/android:ntp_tiles_java", |
| - "//components/policy/android:policy_java", |
| - "//components/precache/android:precache_java", |
| - "//components/safe_json/android:safe_json_java", |
| - "//components/signin/core/browser/android:java", |
| - "//components/sync/android:sync_java", |
| - "//components/url_formatter/android:url_formatter_java", |
| - "//components/web_contents_delegate_android:web_contents_delegate_android_java", |
| - "//ui/base/mojo:mojo_bindings_java", |
| - ] |
| - } |
| + # From java_sources.gni. |
| + java_files = chrome_java_sources |
| + |
| + srcjar_deps += [ |
|
Ted C
2017/01/06 22:00:21
combine this with srcjar_deps above?
F
2017/01/09 21:36:32
Done.
|
| + "//chrome:page_info_connection_type_javagen", |
| + "//chrome:website_settings_action_javagen", |
| + "//components/browsing_data/core:browsing_data_utils_java", |
| + "//components/infobars/core:infobar_enums_java", |
| + "//components/ntp_snippets:ntp_snippets_java_enums_srcjar", |
| + "//components/ntp_tiles:ntp_tiles_enums_java", |
| + "//components/offline_pages/core:offline_page_model_enums_java", |
| + "//components/omnibox/browser:autocomplete_match_javagen", |
| + "//components/omnibox/browser:autocomplete_match_type_javagen", |
| + "//components/security_state/core:security_state_enums_java", |
| + "//components/signin/core/browser:investigated_scenario_java", |
| + ] |
| + |
| + deps += [ |
|
Ted C
2017/01/06 22:00:21
same here with deps
F
2017/01/09 21:36:32
Done.
|
| + ":chrome_java_resources", |
| + ":document_tab_model_info_proto_java", |
| + "//blimp/client/public:public_java", |
| + "//components/bookmarks/common/android:bookmarks_java", |
| + "//components/dom_distiller/content/browser/android:dom_distiller_content_java", |
| + "//components/dom_distiller/core/android:dom_distiller_core_java", |
| + "//components/gcm_driver/android:gcm_driver_java", |
| + "//components/gcm_driver/instance_id/android:instance_id_driver_java", |
| + "//components/invalidation/impl:java", |
| + "//components/location/android:location_java", |
| + "//components/navigation_interception/android:navigation_interception_java", |
| + "//components/ntp_tiles/android:ntp_tiles_java", |
| + "//components/policy/android:policy_java", |
| + "//components/precache/android:precache_java", |
| + "//components/safe_json/android:safe_json_java", |
| + "//components/signin/core/browser/android:java", |
| + "//components/sync/android:sync_java", |
| + "//components/url_formatter/android:url_formatter_java", |
| + "//components/web_contents_delegate_android:web_contents_delegate_android_java", |
| + "//ui/base/mojo:mojo_bindings_java", |
| + ] |
| if (enable_vr_shell || enable_webvr) { |
| java_files += chrome_vr_java_sources |