Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 26196002: Improve partitionAlloc's resistance to fragmentation. (Closed)

Created:
7 years, 2 months ago by Chris Evans
Modified:
7 years, 2 months ago
Reviewers:
Tom Sepez, cevans
CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium
Visibility:
Public.

Description

Improve partitionAlloc's resistance to fragmentation. If we make a full partition page non-full, take steps to get it filled up again because it is unlikely to become fully empty any time soon. If we make a partition page empty, free it right away under more situations. In the process, also apply some tidy-ups and simplifications. Pulling at this thread led to stronger ASSERTs in the allocation slow path, and better unit test coverage. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -33 lines) Patch
M Source/wtf/PartitionAlloc.cpp View 8 chunks +41 lines, -28 lines 0 comments Download
M Source/wtf/PartitionAllocTest.cpp View 3 chunks +57 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cevans
7 years, 2 months ago (2013-10-06 23:28:17 UTC) #1
Tom Sepez
lgtm
7 years, 2 months ago (2013-10-08 18:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/26196002/1
7 years, 2 months ago (2013-10-10 03:22:27 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-10 05:21:36 UTC) #4
Message was sent while issue was closed.
Change committed as 159297

Powered by Google App Engine
This is Rietveld 408576698