Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(972)

Unified Diff: net/http/http_stream_factory_impl_job_controller.h

Issue 2619583002: Clean up HttpStreamFactoryImpl::JobController when Impl::Jobs complete (Closed)
Patch Set: address wez@ comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_basic_stream.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_stream_factory_impl_job_controller.h
diff --git a/net/http/http_stream_factory_impl_job_controller.h b/net/http/http_stream_factory_impl_job_controller.h
index bb18c2f045a81557e9b0656baf4fc3ddb86b5d55..ab829e8fedd809864c14701e9570e644c0e406d6 100644
--- a/net/http/http_stream_factory_impl_job_controller.h
+++ b/net/http/http_stream_factory_impl_job_controller.h
@@ -214,7 +214,8 @@ class HttpStreamFactoryImpl::JobController
void MaybeNotifyFactoryOfCompletion();
- // Called to resume the main job with delay.
+ // Called to resume the main job with delay. Main job is resumed only when
+ // |alternative_job_| has failed or |main_job_wait_time_| elapsed.
void MaybeResumeMainJob(Job* job, const base::TimeDelta& delay);
void ResumeMainJob();
@@ -252,6 +253,9 @@ class HttpStreamFactoryImpl::JobController
// Starts the |alternative_job_|.
void StartAlternativeProxyServerJob();
+ // Returns whether |job| is an orphaned job.
+ bool IsJobOrphaned(Job* job) const;
+
HttpStreamFactoryImpl* factory_;
HttpNetworkSession* session_;
JobFactory* job_factory_;
« no previous file with comments | « net/http/http_basic_stream.cc ('k') | net/http/http_stream_factory_impl_job_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698