Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h

Issue 2619543002: Use a new Supplement constructor in ServiceWorkerContainer (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h
diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h
index 941bc87d092f65b67f92676b9ce573c16f91600d..8a03059330e8a0eca80ce32e96cec984ee793555 100644
--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h
+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h
@@ -26,8 +26,10 @@ class MODULES_EXPORT ServiceWorkerContainerClient final
WTF_MAKE_NONCOPYABLE(ServiceWorkerContainerClient);
public:
- static ServiceWorkerContainerClient* create(
- std::unique_ptr<WebServiceWorkerProvider>);
+ ServiceWorkerContainerClient(Document&,
+ std::unique_ptr<WebServiceWorkerProvider>);
+ ServiceWorkerContainerClient(WorkerClients&,
+ std::unique_ptr<WebServiceWorkerProvider>);
virtual ~ServiceWorkerContainerClient();
WebServiceWorkerProvider* provider() { return m_provider.get(); }
@@ -40,10 +42,7 @@ class MODULES_EXPORT ServiceWorkerContainerClient final
Supplement<WorkerClients>::trace(visitor);
}
- protected:
- explicit ServiceWorkerContainerClient(
- std::unique_ptr<WebServiceWorkerProvider>);
-
+ private:
std::unique_ptr<WebServiceWorkerProvider> m_provider;
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698