src/objects-debug.cc - Issue 261953002: Fix for 3303 MultithreadedParallelIsolates has a race condition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-debug.cc

Issue 261953002: Fix for 3303 MultithreadedParallelIsolates has a race condition. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed ICache arm simulator issue. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-debug.cc

diff --git a/src/objects-debug.cc b/src/objects-debug.cc

index df6392438de57d35cb801a3cdd243ea66904f4b6..7b7c9c9a705c17cde2489a8218b5dd98faa2cbe4 100644

--- a/src/objects-debug.cc

+++ b/src/objects-debug.cc

@@ -627,8 +627,9 @@ void Code::CodeVerify() {

kCodeAlignment));

relocation_info()->ObjectVerify();

Address last_gc_pc = NULL;

+ Isolate* isolate = GetIsolate();

for (RelocIterator it(this); !it.done(); it.next()) {

- it.rinfo()->Verify();

+ it.rinfo()->Verify(isolate);

// Ensure that GC will not iterate twice over the same pointer.

if (RelocInfo::IsGCRelocMode(it.rinfo()->rmode())) {

CHECK(it.rinfo()->pc() != last_gc_pc);

« no previous file with comments | « src/objects.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »