Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: src/isolate.cc

Issue 261953002: Fix for 3303 MultithreadedParallelIsolates has a race condition. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/codegen.h ('K') | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 72df9b4b2b131794190e025049fe65f4e8e51362..2bfa019f45b40bc0257c444240f59c3a18045bb0 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -133,8 +133,8 @@ Isolate::PerIsolateThreadData*
per_thread = new PerIsolateThreadData(this, thread_id);
thread_data_table_->Insert(per_thread);
}
+ ASSERT(thread_data_table_->Lookup(this, thread_id) == per_thread);
}
- ASSERT(thread_data_table_->Lookup(this, thread_id) == per_thread);
return per_thread;
}
@@ -1426,6 +1426,7 @@ Isolate::Isolate()
logger_(NULL),
stats_table_(NULL),
stub_cache_(NULL),
+ no_code_age_sequence_(NULL),
deoptimizer_data_(NULL),
materialized_object_store_(NULL),
capture_stack_trace_for_uncaught_exceptions_(false),
@@ -1660,6 +1661,8 @@ Isolate::~Isolate() {
delete stub_cache_;
stub_cache_ = NULL;
+ delete no_code_age_sequence_;
+ no_code_age_sequence_ = NULL;
delete stats_table_;
stats_table_ = NULL;
@@ -1848,6 +1851,8 @@ bool Isolate::Init(Deserializer* des) {
#endif
#endif
+ no_code_age_sequence_ = new NoCodeAgeSequence();
+
{ // NOLINT
// Ensure that the thread has a valid stack guard. The v8::Locker object
// will ensure this too, but we don't have to use lockers if we are only
« src/codegen.h ('K') | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698