Fix for 3303 MultithreadedParallelIsolates has a race condition.

src/codegen.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CODEGEN_H_
 #define V8_CODEGEN_H_
 
 #include "code-stubs.h"
 #include "runtime.h"
 
@@ skipping 102 matching lines @@
                                      AllocationSiteMode mode,
                                      Label* fail);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ElementsTransitionGenerator);
 };
 
 static const int kNumberDictionaryProbes = 4;
 
 
+class NoCodeAgeSequence {
+ public:
+  NoCodeAgeSequence();
+
+  uint32_t length() const { return sequence_.length(); }
+  bool Match(byte* candidate) const {

[Sven Panne, 2014/05/05 07:54:14]

"IsPrefixOf" describes the intent more closely.

[mvstanton, 2014/05/06 09:55:45]

I ended up generalizing the class, and the notion of "IsYoung()" and "IsOld()"
worked nicely.

+    return memcmp(candidate, sequence_.start(), sequence_.length()) == 0;
+  }
+  void CopyTo(byte* new_buffer) const {
+    CopyBytes(new_buffer, sequence_.start(), sequence_.length());
+  }
+
+ protected:
+  const EmbeddedVector<byte, kNoCodeAgeSequenceLength> sequence_;
+};
+
 } }  // namespace v8::internal
 
 #endif  // V8_CODEGEN_H_