Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp

Issue 2619513002: Add CHECKs to ResourceLoader to investigate crashes (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceLoader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
index dc438c8e512153a3b79514f12ecc1bc7a9c7ce1f..4602882d2b8595b7800a4e5ec5999bc2069acf79 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
@@ -67,7 +67,7 @@ ResourceLoader::ResourceLoader(ResourceFetcher* fetcher, Resource* resource)
}
ResourceLoader::~ResourceLoader() {
- DCHECK(!m_loader);
+ CHECK(!m_loader);
}
DEFINE_TRACE(ResourceLoader) {
@@ -302,6 +302,7 @@ void ResourceLoader::didReceiveResponse(
const WebURLResponse& webURLResponse,
std::unique_ptr<WebDataConsumerHandle> handle) {
DCHECK(!webURLResponse.isNull());
+ CHECK(m_resource);
const ResourceResponse& response = webURLResponse.toResourceResponse();
@@ -354,11 +355,13 @@ void ResourceLoader::didReceiveResponse(
}
}
+ CHECK(m_resource);
context().dispatchDidReceiveResponse(
m_resource->identifier(), response,
m_resource->resourceRequest().frameType(),
m_resource->resourceRequest().requestContext(), m_resource);
+ CHECK(m_resource);
m_resource->responseReceived(response, std::move(handle));
if (!m_resource->loader())
return;
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ResourceLoader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698