Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp

Issue 2619493003: Replace ASSERTs in platform/heap/ with DCHECKs
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp
diff --git a/third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp b/third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp
index 1d164f510a36de4ecb3328e6c80065f4913eca5d..2bddb75acfcda9b34003ab7dc65ad792c108c021 100644
--- a/third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp
+++ b/third_party/WebKit/Source/platform/heap/StackFrameDepth.cpp
@@ -47,9 +47,9 @@ void StackFrameDepth::enableStackLimit() {
static const int kStackRoomSize = 1024;
Address stackBase = reinterpret_cast<Address>(getStackStart());
- RELEASE_ASSERT(stackSize > static_cast<const size_t>(kStackRoomSize));
+ CHECK(stackSize > static_cast<const size_t>(kStackRoomSize));
size_t stackRoom = stackSize - kStackRoomSize;
- RELEASE_ASSERT(stackBase > reinterpret_cast<Address>(stackRoom));
+ CHECK(stackBase > reinterpret_cast<Address>(stackRoom));
m_stackFrameLimit = reinterpret_cast<uintptr_t>(stackBase - stackRoom);
// If current stack use is already exceeding estimated limit, mark as
@@ -85,7 +85,7 @@ size_t StackFrameDepth::getUnderestimatedStackSize() {
void* base;
size_t size;
error = pthread_attr_getstack(&attr, &base, &size);
- RELEASE_ASSERT(!error);
+ CHECK(!error);
pthread_attr_destroy(&attr);
return size;
}
@@ -148,7 +148,7 @@ void* StackFrameDepth::getStackStart() {
void* base;
size_t size;
error = pthread_attr_getstack(&attr, &base, &size);
- RELEASE_ASSERT(!error);
+ CHECK(!error);
pthread_attr_destroy(&attr);
return reinterpret_cast<uint8_t*>(base) + size;
}
@@ -162,7 +162,7 @@ void* StackFrameDepth::getStackStart() {
// See https://code.google.com/p/nativeclient/issues/detail?id=3431.
return __libc_stack_end;
#else
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
#endif
#elif OS(MACOSX)

Powered by Google App Engine
This is Rietveld 408576698