Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: third_party/WebKit/Source/platform/heap/SafePoint.cpp

Issue 2619493003: Replace ASSERTs in platform/heap/ with DCHECKs
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/SafePoint.cpp
diff --git a/third_party/WebKit/Source/platform/heap/SafePoint.cpp b/third_party/WebKit/Source/platform/heap/SafePoint.cpp
index 451a4251f06ec8fdc59ad57e63bc7e639938d091..ab41307f940c6be3650703255381892b17784fac 100644
--- a/third_party/WebKit/Source/platform/heap/SafePoint.cpp
+++ b/third_party/WebKit/Source/platform/heap/SafePoint.cpp
@@ -28,7 +28,7 @@ SafePointBarrier::SafePointBarrier()
SafePointBarrier::~SafePointBarrier() {}
bool SafePointBarrier::parkOthers() {
- ASSERT(ThreadState::current()->isAtSafePoint());
+ DCHECK(ThreadState::current()->isAtSafePoint());
ThreadState* current = ThreadState::current();
// Lock threadAttachMutex() to prevent threads from attaching.
@@ -76,12 +76,12 @@ void SafePointBarrier::resumeOthers(bool barrierLocked) {
}
current->unlockThreadAttachMutex();
- ASSERT(ThreadState::current()->isAtSafePoint());
+ DCHECK(ThreadState::current()->isAtSafePoint());
}
void SafePointBarrier::checkAndPark(ThreadState* state,
SafePointAwareMutexLocker* locker) {
- ASSERT(!state->sweepForbidden());
+ DCHECK(!state->sweepForbidden());
if (acquireLoad(&m_parkingRequested)) {
// If we are leaving the safepoint from a SafePointAwareMutexLocker
// call out to release the lock before going to sleep. This enables the
@@ -95,7 +95,7 @@ void SafePointBarrier::checkAndPark(ThreadState* state,
}
void SafePointBarrier::enterSafePoint(ThreadState* state) {
- ASSERT(!state->sweepForbidden());
+ DCHECK(!state->sweepForbidden());
pushAllRegisters(this, state, enterSafePointAfterPushRegisters);
}

Powered by Google App Engine
This is Rietveld 408576698