Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: third_party/WebKit/Source/platform/heap/PageMemory.h

Issue 2619493003: Replace ASSERTs in platform/heap/ with DCHECKs
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/PageMemory.h
diff --git a/third_party/WebKit/Source/platform/heap/PageMemory.h b/third_party/WebKit/Source/platform/heap/PageMemory.h
index 6e1e87a24d91de89b067376e31b5d8f808f8808b..a82ac1b5b75031fbabcfa3eedb9b41825c74faa2 100644
--- a/third_party/WebKit/Source/platform/heap/PageMemory.h
+++ b/third_party/WebKit/Source/platform/heap/PageMemory.h
@@ -26,7 +26,7 @@ class MemoryRegion {
public:
MemoryRegion(Address base, size_t size) : m_base(base), m_size(size) {
- ASSERT(size > 0);
+ DCHECK_GT(size, 0UL);
}
bool contains(Address addr) const {
@@ -62,7 +62,7 @@ class PageMemoryRegion : public MemoryRegion {
void pageDeleted(Address);
void markPageUsed(Address page) {
- ASSERT(!m_inUse[index(page)]);
+ DCHECK(!m_inUse[index(page)]);
m_inUse[index(page)] = true;
}
@@ -79,7 +79,7 @@ class PageMemoryRegion : public MemoryRegion {
}
BasePage* pageFromAddress(Address address) {
- ASSERT(contains(address));
+ DCHECK(contains(address));
if (!m_inUse[index(address)])
return nullptr;
if (m_isLargePage)
@@ -91,11 +91,11 @@ class PageMemoryRegion : public MemoryRegion {
PageMemoryRegion(Address base, size_t, unsigned numPages, RegionTree*);
unsigned index(Address address) const {
- ASSERT(contains(address));
+ DCHECK(contains(address));
if (m_isLargePage)
return 0;
size_t offset = blinkPageAddress(address) - base();
- ASSERT(offset % blinkPageSize == 0);
+ DCHECK_EQ(offset % blinkPageSize, 0UL);
return offset / blinkPageSize;
}

Powered by Google App Engine
This is Rietveld 408576698