Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/WebKit/Source/platform/heap/MarkingVisitor.h

Issue 2619493003: Replace ASSERTs in platform/heap/ with DCHECKs
Patch Set: temp Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/MarkingVisitor.h
diff --git a/third_party/WebKit/Source/platform/heap/MarkingVisitor.h b/third_party/WebKit/Source/platform/heap/MarkingVisitor.h
index 9416e4dd127ae7cd964b31ca71a4b429f00024e1..b3d758d4b23e6afce5fb2a6b3e82890889224d08 100644
--- a/third_party/WebKit/Source/platform/heap/MarkingVisitor.h
+++ b/third_party/WebKit/Source/platform/heap/MarkingVisitor.h
@@ -42,7 +42,7 @@ class MarkingVisitor final : public Visitor,
Impl::registerWeakTable(closure, iterationCallback, iterationDoneCallback);
}
-#if ENABLE(ASSERT)
+#if DCHECK_IS_ON()
virtual bool weakTableRegistered(const void* closure) {
return Impl::weakTableRegistered(closure);
}
@@ -73,7 +73,7 @@ class MarkingVisitor final : public Visitor,
return true;
BasePage* page = pageFromObject(objectPointer);
- ASSERT(!page->orphaned());
+ DCHECK(!page->orphaned());
// When doing a thread local GC, the marker checks if
// the object resides in another thread's heap. If it
// does, the object should not be marked & traced.

Powered by Google App Engine
This is Rietveld 408576698