Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2731)

Unified Diff: base/i18n/character_encoding_unittest.cc

Issue 2619493002: Let the canonical name of invalid encoding be an empty string (Closed)
Patch Set: std::string Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/i18n/character_encoding.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/i18n/character_encoding_unittest.cc
diff --git a/base/i18n/character_encoding_unittest.cc b/base/i18n/character_encoding_unittest.cc
index f93254b45b5b2c1ac32840e9546c75426d747de0..3c11ba30aa1b6f3eccc92121e5bcdf1f951bf434 100644
--- a/base/i18n/character_encoding_unittest.cc
+++ b/base/i18n/character_encoding_unittest.cc
@@ -9,16 +9,15 @@
namespace base {
TEST(CharacterEncodingTest, GetCanonicalEncodingNameByAliasName) {
- EXPECT_STREQ("Big5", GetCanonicalEncodingNameByAliasName("Big5"));
- EXPECT_STREQ("windows-874",
- GetCanonicalEncodingNameByAliasName("windows-874"));
- EXPECT_STREQ("ISO-8859-8", GetCanonicalEncodingNameByAliasName("ISO-8859-8"));
+ EXPECT_EQ("Big5", GetCanonicalEncodingNameByAliasName("Big5"));
+ EXPECT_EQ("windows-874", GetCanonicalEncodingNameByAliasName("windows-874"));
+ EXPECT_EQ("ISO-8859-8", GetCanonicalEncodingNameByAliasName("ISO-8859-8"));
// Non-canonical alias names should be converted to a canonical one.
- EXPECT_STREQ("UTF-8", GetCanonicalEncodingNameByAliasName("utf8"));
- EXPECT_STREQ("gb18030", GetCanonicalEncodingNameByAliasName("GB18030"));
- EXPECT_STREQ("windows-874", GetCanonicalEncodingNameByAliasName("tis-620"));
- EXPECT_STREQ("EUC-KR", GetCanonicalEncodingNameByAliasName("ks_c_5601-1987"));
+ EXPECT_EQ("UTF-8", GetCanonicalEncodingNameByAliasName("utf8"));
+ EXPECT_EQ("gb18030", GetCanonicalEncodingNameByAliasName("GB18030"));
+ EXPECT_EQ("windows-874", GetCanonicalEncodingNameByAliasName("tis-620"));
+ EXPECT_EQ("EUC-KR", GetCanonicalEncodingNameByAliasName("ks_c_5601-1987"));
}
} // namespace base
« no previous file with comments | « base/i18n/character_encoding.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698