Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: ios/chrome/browser/ui/fullscreen_controller.mm

Issue 2619483002: Cleanup in FullscreenController. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/fullscreen_controller.mm
diff --git a/ios/chrome/browser/ui/fullscreen_controller.mm b/ios/chrome/browser/ui/fullscreen_controller.mm
index f964931605757e58fe6a174eb030f35243f137b4..0e417c614a7d620959e2d1a1d7b134101a012cf6 100644
--- a/ios/chrome/browser/ui/fullscreen_controller.mm
+++ b/ios/chrome/browser/ui/fullscreen_controller.mm
@@ -144,8 +144,6 @@ BOOL CGFloatEquals(CGFloat a, CGFloat b) {
- (void)decrementFullScreenLock;
// Called when the application is about to be the foreground application.
- (void)applicationWillEnterForeground:(NSNotification*)notification;
-// TODO(shreyasv): Make the following methods act on a WebViewScrollView proxy
-// instead of taking in a UIScrollView directly.
// Called from -webViewScrollViewDidScroll: Returns YES if the scroll should be
// ignored.
- (BOOL)shouldIgnoreScroll:(CRWWebViewScrollViewProxy*)webViewScrollViewProxy;
@@ -294,8 +292,7 @@ BOOL CGFloatEquals(CGFloat a, CGFloat b) {
selector:@selector(decrementFullScreenLock)
name:ios_internal::kSideSwipeDidStopNotification
object:nil];
- // TODO(jbbegue): Evaluate using a listener instead of a notification
- // crbug/451373.
+ // TODO(crbug.com/451373): Evaluate using listener instead of notifications.
rohitrao (ping after 24h) 2017/01/10 17:24:02 "Listeners"?
[center addObserver:self
selector:@selector(overscrollActionsWillStart)
name:kOverscrollActionsWillStart
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698