Subzero, MIPS32: Atomic intrinsics fixes

Subzero, MIPS32: Atomic intrinsics fixes

This patch introduces changes to the MIPS32 intrinsic functions to
comply with PNaCl smoke tests.

Also made a change regarding addressing relative to frame pointer,
since it differs in MIPS compared to ARM and x86.

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=298d14e243e0a83abf89bc9d1d29cc95905b0236

[Stefan Maksimovic, 2017-01-10 09:39:32]

Description was changed from

==========
Subzero, MIPS32: Atomic intrinsics fixes

This patch introduces changes to the MIPS32 intrinsic functions to
comply with PNaCl smoke tests.

Also made a change regarding addressing relative to frame pointer,
since it differs in MIPS compared to ARM and x86.
==========

to

==========
Subzero, MIPS32: Atomic intrinsics fixes

This patch introduces changes to the MIPS32 intrinsic functions to
comply with PNaCl smoke tests.

Also made a change regarding addressing relative to frame pointer,
since it differs in MIPS compared to ARM and x86.
==========

[Stefan Maksimovic, 2017-01-10 09:39:32]

makdstefan@gmail.com changed reviewers:
+ jaydeep.patil@imgtec.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[Jim Stichnoth, 2017-01-11 04:55:54]

$ make -f Makefile.standalone check-lit

...
Failing Tests (1):
    subzero :: llvm2ice_tests/fused-alloca.ll

  Expected Passes    : 272
  Unexpected Failures: 1

https://codereview.chromium.org/2619363003/diff/1/src/IceTargetLowering.h
File src/IceTargetLowering.h (right):

https://codereview.chromium.org/2619363003/diff/1/src/IceTargetLowering.h#new...
src/IceTargetLowering.h:256: virtual uint32_t getOffset(uint32_t CurrentOffset,
uint32_t Size) const {
I would prefer a more specific method name.  Maybe something like
  getFramePointerOffset ?  Also a short comment here explaining its intent?

[Stefan Maksimovic, 2017-01-11 09:25:25]

https://codereview.chromium.org/2619363003/diff/1/src/IceTargetLowering.h
File src/IceTargetLowering.h (right):

https://codereview.chromium.org/2619363003/diff/1/src/IceTargetLowering.h#new...
src/IceTargetLowering.h:256: virtual uint32_t getOffset(uint32_t CurrentOffset,
uint32_t Size) const {
On 2017/01/11 04:55:54, Jim Stichnoth wrote:
> I would prefer a more specific method name.  Maybe something like
>   getFramePointerOffset ?  Also a short comment here explaining its intent?

Done.

[Jim Stichnoth, 2017-01-11 13:57:14]

lgtm

[Jim Stichnoth, 2017-01-11 13:58:30]

Description was changed from

==========
Subzero, MIPS32: Atomic intrinsics fixes

This patch introduces changes to the MIPS32 intrinsic functions to
comply with PNaCl smoke tests.

Also made a change regarding addressing relative to frame pointer,
since it differs in MIPS compared to ARM and x86.
==========

to

==========
Subzero, MIPS32: Atomic intrinsics fixes

This patch introduces changes to the MIPS32 intrinsic functions to
comply with PNaCl smoke tests.

Also made a change regarding addressing relative to frame pointer,
since it differs in MIPS compared to ARM and x86.

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2017-01-11 13:58:31]

Committed patchset #2 (id:20001) manually as
298d14e243e0a83abf89bc9d1d29cc95905b0236 (presubmit successful).