Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: src/debug/debug-frames.h

Issue 2619353006: Refactor FrameSummary for JS and Wasm frames (Closed)
Patch Set: Address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/debug-frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-frames.h
diff --git a/src/debug/debug-frames.h b/src/debug/debug-frames.h
index 1165d9e2eee2ccebaf1384e9d67925d0e2a0ab4e..27936937747719754f5c5dcc46166d094b53aa70 100644
--- a/src/debug/debug-frames.h
+++ b/src/debug/debug-frames.h
@@ -15,11 +15,13 @@ namespace internal {
class FrameInspector {
public:
- FrameInspector(StandardFrame* frame, int inlined_jsframe_index,
+ FrameInspector(StandardFrame* frame, int inlined_frame_index,
Isolate* isolate);
~FrameInspector();
+ FrameSummary& summary() { return frame_summary_; }
+
int GetParametersCount();
Handle<JSFunction> GetFunction();
Handle<Script> GetScript();
@@ -33,9 +35,6 @@ class FrameInspector {
return frame_->is_arguments_adaptor() ? ArgumentsAdaptorFrame::cast(frame_)
: JavaScriptFrame::cast(frame_);
}
- inline WasmCompiledFrame* wasm_frame() {
- return WasmCompiledFrame::cast(frame_);
- }
JavaScriptFrame* GetArgumentsFrame() { return javascript_frame(); }
void SetArgumentsFrame(StandardFrame* frame);
@@ -54,6 +53,7 @@ class FrameInspector {
Handle<String> parameter_name);
StandardFrame* frame_;
+ FrameSummary frame_summary_;
DeoptimizedFrameInfo* deoptimized_frame_;
Isolate* isolate_;
bool is_optimized_;
« no previous file with comments | « src/debug/debug.cc ('k') | src/debug/debug-frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698