Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: src/frames-inl.h

Issue 2619353006: Refactor FrameSummary for JS and Wasm frames (Closed)
Patch Set: Address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/frames.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_FRAMES_INL_H_ 5 #ifndef V8_FRAMES_INL_H_
6 #define V8_FRAMES_INL_H_ 6 #define V8_FRAMES_INL_H_
7 7
8 #include "src/frames.h" 8 #include "src/frames.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects-inl.h" 10 #include "src/objects-inl.h"
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 bool StackTraceFrameIterator::is_javascript() const { 311 bool StackTraceFrameIterator::is_javascript() const {
312 return frame()->is_java_script(); 312 return frame()->is_java_script();
313 } 313 }
314 314
315 bool StackTraceFrameIterator::is_wasm() const { return frame()->is_wasm(); } 315 bool StackTraceFrameIterator::is_wasm() const { return frame()->is_wasm(); }
316 316
317 JavaScriptFrame* StackTraceFrameIterator::javascript_frame() const { 317 JavaScriptFrame* StackTraceFrameIterator::javascript_frame() const {
318 return JavaScriptFrame::cast(frame()); 318 return JavaScriptFrame::cast(frame());
319 } 319 }
320 320
321 WasmCompiledFrame* StackTraceFrameIterator::wasm_compiled_frame() const {
322 return WasmCompiledFrame::cast(frame());
323 }
324
325 inline StackFrame* SafeStackFrameIterator::frame() const { 321 inline StackFrame* SafeStackFrameIterator::frame() const {
326 DCHECK(!done()); 322 DCHECK(!done());
327 DCHECK(frame_->is_java_script() || frame_->is_exit() || 323 DCHECK(frame_->is_java_script() || frame_->is_exit() ||
328 frame_->is_builtin_exit()); 324 frame_->is_builtin_exit());
329 return frame_; 325 return frame_;
330 } 326 }
331 327
332 328
333 } // namespace internal 329 } // namespace internal
334 } // namespace v8 330 } // namespace v8
335 331
336 #endif // V8_FRAMES_INL_H_ 332 #endif // V8_FRAMES_INL_H_
OLDNEW
« no previous file with comments | « src/frames.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698