Creates the Suggestions UI

ios/chrome/browser/ui/suggestions/suggestions_view_controller.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_VIEW_CONTROLLER_H_
+#define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_VIEW_CONTROLLER_H_
+
+#import <UIKit/UIKit.h>
+
+#import "ios/chrome/browser/ui/collection_view/collection_view_controller.h"
+#import "ios/chrome/browser/ui/suggestions/suggestions_item.h"
+
+// Actions protocol for the SuggestionsViewController. This protocol will handle
+// the actions sent by the the CollectionViewController.
+@protocol SuggestionsActions

[marq (ping after 24h), 2017/01/10 13:46:25]

It's probably better to put action protocols in their own header files. That
will make them easier to move into ui/actions/ in the future, and it means that
classes that conform to them don't have to depend on the rest of this file.

Or, if this isn't a target/action protocol, it shouldn't be named 'Actions'. If
this protocol is for the view controller layer to communicate with the
coordinator (or other controller object) layer, then it should be named
'SuggestionCommands', and the property on the view controller should be
'suggestionCommandHandler'. In any case, it should still be defined in its own
file.

[gambard, 2017/01/10 14:50:35]

Done.

+
+- (void)addItem;

[marq (ping after 24h), 2017/01/10 13:46:25]

Is this "add some specific item, identified somehow not part of this method
call" or is it "add a new, empty item"? My expectation from the name is that
there would be some kind of parameter specifying the item to add.

[gambard, 2017/01/10 14:50:35]

Those CLs are mainly here for showing what can be done. In the future this
function will probably be removed/changed/parameterized. For now it just adding
a new item.

+
+@end
+
+// Data Source for the SuggestionsViewController.
+@protocol SuggestionsDataSource
+
+// Returns the height of the cell in |collectionView| at |indexPath|.
+- (CGFloat)collectionView:(UICollectionView*)collectionView
+    cellHeightAtIndexPath:(NSIndexPath*)indexPath;
+
+@end
+
+// CollectionViewController to display the suggestions items.
+@interface SuggestionsViewController
+    : CollectionViewController<SuggestionsItemActions>

[marq (ping after 24h), 2017/01/10 13:46:25]

Is conformance  to SuggestionsItemActions an important part of this class's
*public* interface? Generally speaking, view controllers that handle methods
sent up the responder chain do so internally.

[gambard, 2017/01/10 14:50:35]

Done.

+
+@property(nonatomic, assign) id<SuggestionsDataSource> dataSourceDelegate;

[marq (ping after 24h), 2017/01/10 13:46:25]

Please just name the property 'dataSource' to avoid confusion (a collection view
has both a dataSource and a delegate).

[marq (ping after 24h), 2017/01/10 13:46:25]

If this class is using ARC and the property is an object type, it should be
'weak' instead of 'assign'.

[gambard, 2017/01/10 14:50:35]

Done.

[gambard, 2017/01/10 14:50:35]

I have removed it.

+@property(nonatomic, assign) id<SuggestionsActions> actionsDelegate;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_VIEW_CONTROLLER_H_