ios/chrome/browser/ui/suggestions/suggestions_item.h - Issue 2619353004: Creates the Suggestions UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/suggestions/suggestions_item.h

Issue 2619353004: Creates the Suggestions UI (Closed)

Patch Set: Add OWNERS Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ui/suggestions/OWNERS ('k') | ios/chrome/browser/ui/suggestions/suggestions_view_controller.h » ('j') | ios/chrome/browser/ui/suggestions/suggestions_view_controller.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_ITEM_H_

	6 #define IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_ITEM_H_
	marq (ping after 24h) 2017/01/10 13:46:25 Should this just be in a suggestions_item_actions. Should this just be in a suggestions_item_actions.h file? gambard 2017/01/10 14:50:35 Done. Show quoted text On 2017/01/10 13:46:25, marq wrote: > Should this just be in a suggestions_item_actions.h file? Done.
	7

	8 // Protocol handling the actions sent in the responder chain by the suggestion

	9 // items.

	10 @protocol SuggestionsItemActions

	11

	12 // Send through the responder chain when the button of a suggestion item is

	13 // pressed.

	14 - (void)buttonPressed;
	marq (ping after 24h) 2017/01/10 13:46:25 An action should have a specific purpose and not b An action should have a specific purpose and not be a generic UI event. For example, the toolbar actions include -showToolsMenu: and hideToolsMenu: rather than just -toolbarButtonPressed:. So should this be -addItem:? -addContentItem:? For now I would also prefer that action methods by default use the -(void)action:(id)sender signature, even though at the moment we don't heavily rely on the \|sender\| parameter. gambard 2017/01/10 14:50:35 Done. Show quoted text On 2017/01/10 13:46:25, marq wrote: > An action should have a specific purpose and not be a generic UI event. For > example, the toolbar actions include -showToolsMenu: and hideToolsMenu: rather > than just -toolbarButtonPressed:. So should this be -addItem:? -addContentItem:? > > For now I would also prefer that action methods by default use the > -(void)action:(id)sender signature, even though at the moment we don't heavily > rely on the \|sender\| parameter. > Done.
	15

	16 @end

	17

	18 #endif // IOS_CHROME_BROWSER_UI_SUGGESTIONS_SUGGESTIONS_ITEM_H_

OLD	NEW