Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5065)

Unified Diff: chrome/installer/util/google_update_settings.h

Issue 2619323003: Remove uses of BrowserDistribution::CHROME_BINARIES in installer_util. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_update_settings.h
diff --git a/chrome/installer/util/google_update_settings.h b/chrome/installer/util/google_update_settings.h
index 6cdfebcd738bbb1cc1b8d7c1afc839ce863f21c1..e35bafa209624f4f49e87f012a740f0fca103272 100644
--- a/chrome/installer/util/google_update_settings.h
+++ b/chrome/installer/util/google_update_settings.h
@@ -181,24 +181,13 @@ class GoogleUpdateSettings {
// true if this operation succeeded.
static bool ClearReferral();
- // Convenience routine: UpdateDidRunStateForApp() specialized for the current
- // BrowserDistribution, and also updates Chrome Binary's did_run if the
- // current distribution is multi-install.
+ // Updates Chrome's "did run" state, returning true if the update succeeds.
static bool UpdateDidRunState(bool did_run, bool system_level);
- // Returns only the channel name: "" (stable), "dev", "beta", "canary", or
- // "unknown" if unknown. This value will not be modified by "-m" for a
- // multi-install. See kChromeChannel* in util_constants.h
+ // Returns the channel name: "" (stable), "dev", "beta", "canary", or
+ // "unknown" if unknown. See kChromeChannel* in util_constants.h
static base::string16 GetChromeChannel(bool system_install);
- // Return a human readable modifier for the version string, e.g.
- // the channel (dev, beta, stable). Returns true if this operation succeeded,
- // on success, channel contains one of "", "unknown", "dev" or "beta" (unless
- // it is a multi-install product, in which case it will return "m",
- // "unknown-m", "dev-m", or "beta-m").
- static bool GetChromeChannelAndModifiers(bool system_install,
- base::string16* channel);
-
// This method changes the Google Update "ap" value to move the installation
// on to or off of one of the recovery channels.
// - If incremental installer fails we append a magic string ("-full"), if

Powered by Google App Engine
This is Rietveld 408576698