Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2619273002: Android: Stop generating proguard dump.txt (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
Reviewers:
F
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Stop generating proguard dump.txt This is a ~100mb file that isn't actaully used by anything, and that can be created after-the-fact by a class-dumping tool BUG=none

Patch Set 1 #

Patch Set 2 : Android: Stop generating proguard dump.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/android/gyp/util/proguard_util.py View 1 2 chunks +0 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
agrieve
On 2017/01/11 15:08:13, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:zpeng@chromium.org
3 years, 11 months ago (2017-01-11 15:08:19 UTC) #7
F
lgtm lgtm
3 years, 11 months ago (2017-01-11 15:22:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619273002/20001
3 years, 11 months ago (2017-01-11 15:26:09 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98170)
3 years, 11 months ago (2017-01-11 16:56:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2619273002/20001
3 years, 11 months ago (2017-01-12 16:16:17 UTC) #14
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-12 17:36:54 UTC) #17
agrieve
3 years, 11 months ago (2017-01-12 17:43:05 UTC) #18
Message was sent while issue was closed.
On 2017/01/12 17:36:54, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

committed.

Powered by Google App Engine
This is Rietveld 408576698