Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.h

Issue 2619243003: Adding ExtraRequest info and exposing request to PLM observers (Closed)
Patch Set: comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_tracker.h
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.h b/chrome/browser/page_load_metrics/page_load_tracker.h
index b58a86385d38453e4a239836ee9a60a985f2238f..b9cff3a5d7640a28e7e586259b51b9adcd59b5b1 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.h
+++ b/chrome/browser/page_load_metrics/page_load_tracker.h
@@ -152,7 +152,7 @@ class PageLoadTracker {
bool UpdateTiming(const PageLoadTiming& timing,
const PageLoadMetadata& metadata);
- void OnLoadedResource(bool was_cached, int64_t raw_body_bytes);
+ void OnLoadedResource(const ExtraRequestInfo& extra_request_info);
// Signals that we should stop tracking metrics for the associated page load.
// We may stop tracking a page load if it doesn't meet the criteria for
@@ -279,17 +279,6 @@ class PageLoadTracker {
ui::PageTransition page_transition_;
- // Note: these are only approximations, based on WebContents attribution from
- // ResourceRequestInfo objects while this is the currently committed load in
- // the WebContents.
- int num_cache_requests_;
- int num_network_requests_;
-
- // The number of body (not header) prefilter bytes consumed by requests for
- // the page.
- int64_t cache_bytes_;
- int64_t network_bytes_;
-
// Whether this page load was user initiated.
UserInitiatedInfo user_initiated_info_;
« no previous file with comments | « chrome/browser/page_load_metrics/page_load_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698