Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5511)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2619243003: Adding ExtraRequest info and exposing request to PLM observers (Closed)
Patch Set: comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
index 98f7df39730e4a8e17ff107396999b787ec170ba..ff9a8d666bb391072dcf2c777be0208067ecb046 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
@@ -109,6 +109,8 @@ class CorePageLoadMetricsObserver
const page_load_metrics::FailedProvisionalLoadInfo& failed_load_info,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
void OnUserInput(const blink::WebInputEvent& event) override;
+ void OnLoadedResource(
+ const page_load_metrics::ExtraRequestInfo& extra_request_info) override;
private:
void RecordTimingHistograms(const page_load_metrics::PageLoadTiming& timing,
@@ -119,6 +121,17 @@ class CorePageLoadMetricsObserver
ui::PageTransition transition_;
bool was_no_store_main_resource_;
+ // Note: these are only approximations, based on WebContents attribution from
+ // ResourceRequestInfo objects while this is the currently committed load in
+ // the WebContents.
+ int num_cache_requests_;
+ int num_network_requests_;
+
+ // The number of body (not header) prefilter bytes consumed by requests for
+ // the page.
+ int64_t cache_bytes_;
+ int64_t network_bytes_;
+
// True if we've received a non-scroll input (touch tap or mouse up)
// after first paint has happened.
bool received_non_scroll_input_after_first_paint_ = false;

Powered by Google App Engine
This is Rietveld 408576698