Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2619243002: Make .enclosingClass always return the declaration (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make .enclosingClass always return the declaration This aligns the semantics of the Element model with the Entity model. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9f4774cc81ed2da9f67f6268cdce947fcc13782e

Patch Set 1 #

Patch Set 2 : Add comment. #

Total comments: 6

Patch Set 3 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart#newcode2312 pkg/compiler/lib/src/js_backend/backend.dart:2312: : constantImpactsForCodegen; Latent error found while debugging the problem ...
3 years, 11 months ago (2017-01-09 12:58:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/js_backend/backend.dart#newcode2312 pkg/compiler/lib/src/js_backend/backend.dart:2312: : constantImpactsForCodegen; On 2017/01/09 12:58:03, Johnni Winther wrote: ...
3 years, 11 months ago (2017-01-11 19:24:02 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 9f4774cc81ed2da9f67f6268cdce947fcc13782e (presubmit successful).
3 years, 11 months ago (2017-01-12 09:56:19 UTC) #5
Johnni Winther
3 years, 11 months ago (2017-01-12 09:56:56 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2364: // Use [enclosingElement] to
process patch class metadata for patch
On 2017/01/11 19:24:02, Siggi Cherem (dart-lang) wrote:
> nit: maybe highlight also that you are not using enclosingClass for that
reason?

Done.

https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/constructors.dart (right):

https://codereview.chromium.org/2619243002/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/constructors.dart:101: // Use [enclosingElement]
ensure lookup in patch class when necessary.
On 2017/01/11 19:24:02, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

Powered by Google App Engine
This is Rietveld 408576698