Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: BUILD.gn

Issue 2619213002: [build] Introduce an embedder version string (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gypfiles/features.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 2f065a0504bc5416fe89898850d5f67c049ce662..7197da08e02d92de1f135609c7738a6b2fd2bd31 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -29,6 +29,9 @@ declare_args() {
# Enable compiler warnings when using V8_DEPRECATED apis.
v8_deprecation_warnings = false
+ # Allow the embedder to add a custom suffix to the version string.
+ v8_embedder_string = ""
+
# Enable compiler warnings when using V8_DEPRECATE_SOON apis.
v8_imminent_deprecation_warnings = ""
@@ -189,6 +192,10 @@ config("features") {
defines = []
+ if (v8_embedder_string != "") {
+ defines += [ "V8_EMBEDDER_STRING=\"$v8_embedder_string\"" ]
+ }
+
if (v8_enable_disassembler) {
defines += [ "ENABLE_DISASSEMBLER" ]
}
« no previous file with comments | « no previous file | gypfiles/features.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698