Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: test/cctest/test-version.cc

Issue 2619213002: [build] Introduce an embedder version string (Closed)
Patch Set: rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/version.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 #include "src/version.h" 30 #include "src/version.h"
31 #include "test/cctest/cctest.h" 31 #include "test/cctest/cctest.h"
32 32
33 using namespace v8::internal; 33 using namespace v8::internal;
34 34
35 35
36 namespace v8 { 36 namespace v8 {
37 namespace internal { 37 namespace internal {
38 38
39 void SetVersion(int major, int minor, int build, int patch, 39 void SetVersion(int major, int minor, int build, int patch,
40 bool candidate, const char* soname) { 40 const char* embedder, bool candidate, const char* soname) {
41 Version::major_ = major; 41 Version::major_ = major;
42 Version::minor_ = minor; 42 Version::minor_ = minor;
43 Version::build_ = build; 43 Version::build_ = build;
44 Version::patch_ = patch; 44 Version::patch_ = patch;
45 Version::embedder_ = embedder;
45 Version::candidate_ = candidate; 46 Version::candidate_ = candidate;
46 Version::soname_ = soname; 47 Version::soname_ = soname;
47 } 48 }
48 49
49 } // namespace internal 50 } // namespace internal
50 } // namespace v8 51 } // namespace v8
51 52
52 53 static void CheckVersion(int major, int minor, int build, int patch,
53 static void CheckVersion(int major, int minor, int build, 54 const char* embedder, bool candidate,
54 int patch, bool candidate,
55 const char* expected_version_string, 55 const char* expected_version_string,
56 const char* expected_generic_soname) { 56 const char* expected_generic_soname) {
57 static v8::internal::EmbeddedVector<char, 128> version_str; 57 static v8::internal::EmbeddedVector<char, 128> version_str;
58 static v8::internal::EmbeddedVector<char, 128> soname_str; 58 static v8::internal::EmbeddedVector<char, 128> soname_str;
59
60 // Test version without specific SONAME. 59 // Test version without specific SONAME.
61 SetVersion(major, minor, build, patch, candidate, ""); 60 SetVersion(major, minor, build, patch, embedder, candidate, "");
62 Version::GetString(version_str); 61 Version::GetString(version_str);
63 CHECK_EQ(0, strcmp(expected_version_string, version_str.start())); 62 CHECK_EQ(0, strcmp(expected_version_string, version_str.start()));
64 Version::GetSONAME(soname_str); 63 Version::GetSONAME(soname_str);
65 CHECK_EQ(0, strcmp(expected_generic_soname, soname_str.start())); 64 CHECK_EQ(0, strcmp(expected_generic_soname, soname_str.start()));
66 65
67 // Test version with specific SONAME. 66 // Test version with specific SONAME.
68 const char* soname = "libv8.so.1"; 67 const char* soname = "libv8.so.1";
69 SetVersion(major, minor, build, patch, candidate, soname); 68 SetVersion(major, minor, build, patch, embedder, candidate, soname);
70 Version::GetString(version_str); 69 Version::GetString(version_str);
71 CHECK_EQ(0, strcmp(expected_version_string, version_str.start())); 70 CHECK_EQ(0, strcmp(expected_version_string, version_str.start()));
72 Version::GetSONAME(soname_str); 71 Version::GetSONAME(soname_str);
73 CHECK_EQ(0, strcmp(soname, soname_str.start())); 72 CHECK_EQ(0, strcmp(soname, soname_str.start()));
74 } 73 }
75 74
76 75
77 TEST(VersionString) { 76 TEST(VersionString) {
78 #ifdef USE_SIMULATOR 77 #ifdef USE_SIMULATOR
79 CheckVersion(0, 0, 0, 0, false, "0.0.0 SIMULATOR", "libv8-0.0.0.so"); 78 CheckVersion(0, 0, 0, 0, "", false, "0.0.0 SIMULATOR", "libv8-0.0.0.so");
80 CheckVersion(0, 0, 0, 0, true, 79 CheckVersion(0, 0, 0, 0, "", true, "0.0.0 (candidate) SIMULATOR",
81 "0.0.0 (candidate) SIMULATOR", "libv8-0.0.0-candidate.so"); 80 "libv8-0.0.0-candidate.so");
82 CheckVersion(1, 0, 0, 0, false, "1.0.0 SIMULATOR", "libv8-1.0.0.so"); 81 CheckVersion(1, 0, 0, 0, "", false, "1.0.0 SIMULATOR", "libv8-1.0.0.so");
83 CheckVersion(1, 0, 0, 0, true, 82 CheckVersion(1, 0, 0, 0, "", true, "1.0.0 (candidate) SIMULATOR",
84 "1.0.0 (candidate) SIMULATOR", "libv8-1.0.0-candidate.so"); 83 "libv8-1.0.0-candidate.so");
85 CheckVersion(1, 0, 0, 1, false, "1.0.0.1 SIMULATOR", "libv8-1.0.0.1.so"); 84 CheckVersion(1, 0, 0, 1, "", false, "1.0.0.1 SIMULATOR", "libv8-1.0.0.1.so");
86 CheckVersion(1, 0, 0, 1, true, 85 CheckVersion(1, 0, 0, 1, "", true, "1.0.0.1 (candidate) SIMULATOR",
87 "1.0.0.1 (candidate) SIMULATOR", "libv8-1.0.0.1-candidate.so"); 86 "libv8-1.0.0.1-candidate.so");
88 CheckVersion(2, 5, 10, 7, false, "2.5.10.7 SIMULATOR", "libv8-2.5.10.7.so"); 87 CheckVersion(2, 5, 10, 7, "", false, "2.5.10.7 SIMULATOR",
89 CheckVersion(2, 5, 10, 7, true, 88 "libv8-2.5.10.7.so");
90 "2.5.10.7 (candidate) SIMULATOR", "libv8-2.5.10.7-candidate.so"); 89 CheckVersion(2, 5, 10, 7, "", true, "2.5.10.7 (candidate) SIMULATOR",
90 "libv8-2.5.10.7-candidate.so");
91 CheckVersion(2, 5, 10, 7, ".emb.1", false, "2.5.10.7.emb.1 SIMULATOR",
92 "libv8-2.5.10.7.emb.1.so");
93 CheckVersion(2, 5, 10, 7, ".emb.1", true,
94 "2.5.10.7.emb.1 (candidate) SIMULATOR",
95 "libv8-2.5.10.7.emb.1-candidate.so");
91 #else 96 #else
92 CheckVersion(0, 0, 0, 0, false, "0.0.0", "libv8-0.0.0.so"); 97 CheckVersion(0, 0, 0, 0, "", false, "0.0.0", "libv8-0.0.0.so");
93 CheckVersion(0, 0, 0, 0, true, 98 CheckVersion(0, 0, 0, 0, "", true, "0.0.0 (candidate)",
94 "0.0.0 (candidate)", "libv8-0.0.0-candidate.so"); 99 "libv8-0.0.0-candidate.so");
95 CheckVersion(1, 0, 0, 0, false, "1.0.0", "libv8-1.0.0.so"); 100 CheckVersion(1, 0, 0, 0, "", false, "1.0.0", "libv8-1.0.0.so");
96 CheckVersion(1, 0, 0, 0, true, 101 CheckVersion(1, 0, 0, 0, "", true, "1.0.0 (candidate)",
97 "1.0.0 (candidate)", "libv8-1.0.0-candidate.so"); 102 "libv8-1.0.0-candidate.so");
98 CheckVersion(1, 0, 0, 1, false, "1.0.0.1", "libv8-1.0.0.1.so"); 103 CheckVersion(1, 0, 0, 1, "", false, "1.0.0.1", "libv8-1.0.0.1.so");
99 CheckVersion(1, 0, 0, 1, true, 104 CheckVersion(1, 0, 0, 1, "", true, "1.0.0.1 (candidate)",
100 "1.0.0.1 (candidate)", "libv8-1.0.0.1-candidate.so"); 105 "libv8-1.0.0.1-candidate.so");
101 CheckVersion(2, 5, 10, 7, false, "2.5.10.7", "libv8-2.5.10.7.so"); 106 CheckVersion(2, 5, 10, 7, "", false, "2.5.10.7", "libv8-2.5.10.7.so");
102 CheckVersion(2, 5, 10, 7, true, 107 CheckVersion(2, 5, 10, 7, "", true, "2.5.10.7 (candidate)",
103 "2.5.10.7 (candidate)", "libv8-2.5.10.7-candidate.so"); 108 "libv8-2.5.10.7-candidate.so");
109 CheckVersion(2, 5, 10, 7, ".emb.1", false, "2.5.10.7.emb.1",
110 "libv8-2.5.10.7.emb.1.so");
111 CheckVersion(2, 5, 10, 7, ".emb.1", true, "2.5.10.7.emb.1 (candidate)",
112 "libv8-2.5.10.7.emb.1-candidate.so");
104 #endif 113 #endif
105 } 114 }
OLDNEW
« no previous file with comments | « src/version.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698