Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2619193003: Insert implicit downcasts in kernel strong mode. (Closed)

Created:
3 years, 11 months ago by asgerf
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Insert implicit downcasts in kernel strong mode. This is implemented as a separate pass, although going forward I would like the new frontend to insert these checks. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/8dd2b15951a51411c3c0016880f746915af6bfa5

Patch Set 1 #

Patch Set 2 : Sort status lines #

Patch Set 3 : Add missing status line #

Total comments: 2

Patch Set 4 : Ensure space before function type, and revert changes to closures test expectations #

Patch Set 5 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -63 lines) Patch
M pkg/kernel/lib/analyzer/ast_from_analyzer.dart View 1 2 3 4 7 chunks +50 lines, -6 lines 0 comments Download
M pkg/kernel/lib/ast.dart View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M pkg/kernel/lib/repository.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/lib/target/vm.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/kernel/lib/text/ast_to_text.dart View 1 2 3 4 2 chunks +9 lines, -0 lines 0 comments Download
A pkg/kernel/lib/transformations/insert_type_checks.dart View 1 chunk +58 lines, -0 lines 0 comments Download
M pkg/kernel/lib/type_checker.dart View 17 chunks +70 lines, -32 lines 0 comments Download
M pkg/kernel/lib/type_environment.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M pkg/kernel/lib/verifier.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/DeltaBlue.baseline.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/call.baseline.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/optional.baseline.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/kernel/testcases/strong-mode/void-methods.baseline.txt View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib_strong/corelib_strong_kernel.status View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/language_strong/language_strong_kernel.status View 1 5 chunks +7 lines, -1 line 0 comments Download
M tests/lib_strong/lib_strong_kernel.status View 1 2 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
asgerf
3 years, 11 months ago (2017-01-09 13:29:40 UTC) #2
asgerf
On 2017/01/09 13:29:40, asgerf wrote: Friendly ping. The other strong mode CL was based on ...
3 years, 11 months ago (2017-01-10 15:22:35 UTC) #3
Kevin Millikin (Google)
LGTM https://codereview.chromium.org/2619193003/diff/40001/pkg/kernel/testcases/closures/capture_closure.dart.expect File pkg/kernel/testcases/closures/capture_closure.dart.expect (right): https://codereview.chromium.org/2619193003/diff/40001/pkg/kernel/testcases/closures/capture_closure.dart.expect#newcode34 pkg/kernel/testcases/closures/capture_closure.dart.expect:34: final() → dynamic g = new self::Closure#main#g::•(#context); It ...
3 years, 11 months ago (2017-01-11 12:00:58 UTC) #4
asgerf
https://codereview.chromium.org/2619193003/diff/40001/pkg/kernel/testcases/closures/capture_closure.dart.expect File pkg/kernel/testcases/closures/capture_closure.dart.expect (right): https://codereview.chromium.org/2619193003/diff/40001/pkg/kernel/testcases/closures/capture_closure.dart.expect#newcode34 pkg/kernel/testcases/closures/capture_closure.dart.expect:34: final() → dynamic g = new self::Closure#main#g::•(#context); On 2017/01/11 ...
3 years, 11 months ago (2017-01-11 12:15:12 UTC) #5
asgerf
3 years, 11 months ago (2017-01-11 12:47:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
8dd2b15951a51411c3c0016880f746915af6bfa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698