Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2541)

Unified Diff: content/common/frame_messages.h

Issue 2619123002: Fix remote-to-local navigations in crashed subframes. (Closed)
Patch Set: Self-review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 9f65e60eef8ec63bb6acc6f7023c84ff02e0a4d0..1da8340e0ea8cb40b0cdcdce83c401b0ffd0ae0a 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -663,6 +663,14 @@ IPC_MESSAGE_ROUTED3(FrameMsg_SwapOut,
bool /* is_loading */,
content::FrameReplicationState /* replication_state */)
+// Requests that a provisional RenderFrame swaps itself into the frame tree,
Charlie Reis 2017/01/12 00:29:05 nit: s/swaps/swap/
alexmos 2017/01/12 01:38:12 Done.
+// replacing the RenderFrameProxy that it is associated with. This is used
+// with remote-to-local frame navigations when the RenderFrameProxy corresponds
+// to a non-live (crashed) frame. In that case, the browser process will send
+// this message as part of an early commit to stop showing the sad iframe
+// without waiting for the provisional RenderFrame's navigation to commit.
+IPC_MESSAGE_ROUTED0(FrameMsg_SwapIn)
+
// Instructs the frame to stop the load in progress, if any.
IPC_MESSAGE_ROUTED0(FrameMsg_Stop)
@@ -720,8 +728,8 @@ IPC_MESSAGE_ROUTED2(FrameMsg_DidChooseColorResponse, unsigned, SkColor)
// Notifies the color chooser client that the color chooser has ended.
IPC_MESSAGE_ROUTED1(FrameMsg_DidEndColorChooser, unsigned)
-// Notifies the corresponding RenderFrameProxy object to replace itself with the
-// RenderFrame object it is associated with.
+// Requests the corresponding RenderFrameProxy to be deleted and removed from
+// the frame tree.
IPC_MESSAGE_ROUTED0(FrameMsg_DeleteProxy)
// Request the text surrounding the selection with a |max_length|. The response

Powered by Google App Engine
This is Rietveld 408576698