Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 2619123002: Fix remote-to-local navigations in crashed subframes. (Closed)
Patch Set: Charlie's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 void RemoveObserver(RenderFrameObserver* observer); 782 void RemoveObserver(RenderFrameObserver* observer);
783 783
784 bool IsLocalRoot() const; 784 bool IsLocalRoot() const;
785 const RenderFrameImpl* GetLocalRoot() const; 785 const RenderFrameImpl* GetLocalRoot() const;
786 786
787 // Builds and sends DidCommitProvisionalLoad to the host. 787 // Builds and sends DidCommitProvisionalLoad to the host.
788 void SendDidCommitProvisionalLoad(blink::WebFrame* frame, 788 void SendDidCommitProvisionalLoad(blink::WebFrame* frame,
789 blink::WebHistoryCommitType commit_type, 789 blink::WebHistoryCommitType commit_type,
790 const blink::WebHistoryItem& item); 790 const blink::WebHistoryItem& item);
791 791
792 // Swaps the current frame into the frame tree, replacing the
793 // RenderFrameProxy it is associated with. Return value indicates whether
794 // the swap operation succeeded. This should only be used for provisional
795 // frames associated with a proxy, while the proxy is still in the frame
796 // tree. If the associated proxy has been detached before this is called,
797 // this returns false and aborts the swap.
798 bool SwapIn();
799
792 // IPC message handlers ------------------------------------------------------ 800 // IPC message handlers ------------------------------------------------------
793 // 801 //
794 // The documentation for these functions should be in 802 // The documentation for these functions should be in
795 // content/common/*_messages.h for the message that the function is handling. 803 // content/common/*_messages.h for the message that the function is handling.
796 void OnNavigate(const CommonNavigationParams& common_params, 804 void OnNavigate(const CommonNavigationParams& common_params,
797 const StartNavigationParams& start_params, 805 const StartNavigationParams& start_params,
798 const RequestNavigationParams& request_params); 806 const RequestNavigationParams& request_params);
799 void OnBeforeUnload(bool is_reload); 807 void OnBeforeUnload(bool is_reload);
808 void OnSwapIn();
800 void OnSwapOut(int proxy_routing_id, 809 void OnSwapOut(int proxy_routing_id,
801 bool is_loading, 810 bool is_loading,
802 const FrameReplicationState& replicated_frame_state); 811 const FrameReplicationState& replicated_frame_state);
803 void OnDeleteFrame(); 812 void OnDeleteFrame();
804 void OnStop(); 813 void OnStop();
805 void OnShowContextMenu(const gfx::Point& location); 814 void OnShowContextMenu(const gfx::Point& location);
806 void OnContextMenuClosed(const CustomContextMenuContext& custom_context); 815 void OnContextMenuClosed(const CustomContextMenuContext& custom_context);
807 void OnCustomContextMenuAction(const CustomContextMenuContext& custom_context, 816 void OnCustomContextMenuAction(const CustomContextMenuContext& custom_context,
808 unsigned action); 817 unsigned action);
809 void OnUndo(); 818 void OnUndo();
(...skipping 554 matching lines...) Expand 10 before | Expand all | Expand 10 after
1364 bool browser_side_navigation_pending_ = false; 1373 bool browser_side_navigation_pending_ = false;
1365 1374
1366 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 1375 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
1367 1376
1368 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 1377 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
1369 }; 1378 };
1370 1379
1371 } // namespace content 1380 } // namespace content
1372 1381
1373 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 1382 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698