Hook ByteArrayViewLoad operations into polymorphic inliner

runtime/lib/typed_data.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // patch classes for Int8List ..... Float64List and ByteData implementations.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
@@ skipping 677 matching lines @@
     return Uint8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
   _Uint8Array _createList(int length) {
     return _new(length);
   }
 
+  int _getUint8(int offsetInBytes) native "TypedData_GetUint8";

[Cutch, 2013/10/07 23:49:50]

I have to override _getUint8 in _Uint8Array and _ExternalUint8Array (see below)
so that the IC data has more than one target. Without this change the optimizer
and polymorphic inliner think the call site has a single target (correctly) but
the target itself determines the class id and does the right thing.

The problem is that we have ~18 TypedArray classes and would need 18*18 methods
(and add them all to the method recognizer— and that's just counting the load
operations) to support a load of any type from a view of any type. We could
support few but common configurations.

+
   static _Uint8Array _new(int length) native "TypedData_Uint8Array_new";
 }
 
 
 class _Uint8ClampedArray extends _TypedList implements Uint8ClampedList {
   // Factory constructors.
 
   factory _Uint8ClampedArray(int length) {
     return _new(length);
   }
@@ skipping 690 matching lines @@
     return Uint8List.BYTES_PER_ELEMENT;
   }
 
 
   // Internal utility methods.
 
   Uint8List _createList(int length) {
     return new Uint8List(length);
   }
 
+  int _getUint8(int offsetInBytes) native "TypedData_GetUint8";
+
   static _ExternalUint8Array _new(int length) native
       "ExternalTypedData_Uint8Array_new";
 }
 
 
 class _ExternalUint8ClampedArray extends _TypedList implements Uint8ClampedList {
   // Factory constructors.
 
   factory _ExternalUint8ClampedArray(int length) {
     return _new(length);
@@ skipping 1735 matching lines @@
     return value;
   }
   return object;
 }
 
 
 void _throwRangeError(int index, int length) {
   String message = "$index must be in the range [0..$length)";
   throw new RangeError(message);
 }