telemetry/telemetry/timeline/tab_id_importer.py - Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/timeline/tab_id_importer.py

Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/timeline/tab_id_importer.py

diff --git a/telemetry/telemetry/timeline/tab_id_importer.py b/telemetry/telemetry/timeline/tab_id_importer.py

index 1f041662137577d02304dc1c93fd34df69711012..e0d85dd135a414da0e2582b0e9b987f6b7520e8e 100644

--- a/telemetry/telemetry/timeline/tab_id_importer.py

+++ b/telemetry/telemetry/timeline/tab_id_importer.py

@@ -45,8 +45,9 @@ class TabIdImporter(importer.TimelineImporter):

repr(self._trace_data)))

def _CreateTabIdsToThreadsMap(self):

- tab_id_events = self._trace_data.GetTraceFor(

- trace_data_module.TAB_ID_PART)

+ tab_id_events = []

+ for tab_ids in self._trace_data.GetTracesFor(trace_data_module.TAB_ID_PART):

+ tab_id_events.extend(tab_ids)

for tab_id in tab_id_events:

try: