telemetry/telemetry/internal/platform/tracing_controller_backend.py - Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/tracing_controller_backend.py

Issue 2619073002: [Telemetry] Change trace_data to hold a list of raw trace data for each trace part (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend_unittest.py ('K') | « telemetry/telemetry/internal/platform/tracing_agent/display_tracing_agent.py ('k') | telemetry/telemetry/internal/platform/tracing_controller_backend_unittest.py » ('j') | telemetry/telemetry/value/trace.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/tracing_controller_backend.py

diff --git a/telemetry/telemetry/internal/platform/tracing_controller_backend.py b/telemetry/telemetry/internal/platform/tracing_controller_backend.py

index f5da75ab857f00e4c19e4043db08c14b430e2c6d..56a6ba0d22d6ff07a55b0d191ac5058eb34a7d2d 100644

--- a/telemetry/telemetry/internal/platform/tracing_controller_backend.py

+++ b/telemetry/telemetry/internal/platform/tracing_controller_backend.py

@@ -249,7 +249,7 @@ class TracingControllerBackend(object):

assert not trace_event.trace_is_enabled(), 'Stop tracing before collection.'

with open(self._trace_log, 'r') as fp:

data = ast.literal_eval(fp.read() + ']')

- trace_data_builder.SetTraceFor(trace_data_module.TELEMETRY_PART, {

+ trace_data_builder.AddTraceFor(trace_data_module.TELEMETRY_PART, {

"traceEvents": data,

"metadata": {

# TODO(charliea): For right now, we use "TELEMETRY" as the clock